Replace FreeDB lookup with AccurateRip Meta [3/4] - #405
Open
andrewiethoff wants to merge 22 commits into
Open
Conversation
The provider was gated behind "no other release was found, or the search mode is Extensive", mirroring how the now dormant FreeDB lookup had been wired as a last resort. Since CTDB answers for virtually every recognised disc, that meant AccurateRip Meta was never consulted on the initial lookup: its release, its track metadata and its cover art only appeared after pressing Reload. Treat it as a peer of the CTDB metadata sources instead - whenever CTDB is asked for metadata, ask AccurateRip Meta too. A configured search mode of None still suppresses both. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RSHyfpM8tS5fv5bX2fn5Lk
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge order: 3 of 4
Depends on
dotnet10-update(#403). Independent of #404 — the two are sibling branches offdotnet10-updateand neither contains the other, so they may be merged in either order. #406 builds on this one.dotnet10-updatesecurity-auditfeat/accuraterip-meta-implementationfix/net10-build-output-and-assembly-resolutionWhat this does
Replaces the FreeDB metadata lookup with a provider backed by the AccurateRip metadata endpoint, and makes the FreeDB code dormant rather than deleting it.
AccurateRipMetabuilds the request disc ID and body, posts to the endpoint and maps the response ontoCUEMetadataEntry, tolerating malformed and surplus tracks and unordered extra tracks.IAccurateRipMetaTransportseam with anHttpWebRequestimplementation that sets bothTimeoutandReadWriteTimeout, disables auto-redirect and 100-continue, enables gzip/deflate, and supports cooperative cancellation through a stop watcher. Non-cancellation failures are swallowed and reported as "no result" so a dead endpoint cannot break a lookup.EnableDormantFreedb/DORMANT_FREEDBswitch that is off by default, so nothing is lost if the service returns.CUESheetalbum lookup, and in CUERipper it is queried whenever CTDB is asked for metadata, so its release and cover art appear on the first lookup rather than only after Reload.Scope
21 commits, 26 files, +3775 / −466 — a large share of which is test code:
AccurateRipMetaTest.cscovers the mapper, the HTTP transport contract, HTTPS handling, malformed and surplus track tolerance, and edge cases, against a recorded response fixture. Design notes and the implementation plan are included underdocs/.Note on reviewing this stack
All four PRs target
master, because a cross-fork pull request can only target a branch that exists in this repository. Until #403 merges, this diff also contains its commit.